Fix for issue #1199 (regression against scapy<=2.3.2).#1282
Merged
p-l- merged 1 commit intosecdev:masterfrom Mar 24, 2018
Merged
Fix for issue #1199 (regression against scapy<=2.3.2).#1282p-l- merged 1 commit intosecdev:masterfrom
p-l- merged 1 commit intosecdev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
- Coverage 84.79% 84.79% -0.01%
==========================================
Files 160 160
Lines 38322 38340 +18
==========================================
+ Hits 32495 32510 +15
- Misses 5827 5830 +3
|
Member
1e6640e to
298d401
Compare
298d401 to
92637c4
Compare
Member
92637c4 to
d4eb327
Compare
Contributor
Author
|
@gpotter2 Fixed |
Member
|
@guedou You should review it again, changes are big |
gpotter2
reviewed
Mar 23, 2018
scapy/sendrecv.py
Outdated
Member
There was a problem hiding this comment.
I understand why you removed this try, but this PR itself is already tricky, and it makes it real hard to review + is not needed.
If it’s not bothering you too much, it would be better that you leave the current useless try.
All of those fixes will surely be fixed through the PEPin project, which will come in time
test/regression.uts
Outdated
Member
There was a problem hiding this comment.
The logic between ˋsrandsr1` is the same. Because networking tests tend to fail more often, it would be good not to have too many doing the same thing :)
d4eb327 to
8725782
Compare
Contributor
Author
|
PR is ready for merge to the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Scapy Version: 2.4.0rc5-64
System: Windows7/Windows10
Python Version: 2.7.14/3.4.4/3.6.4
This PR fixes #1199 (regression against scapy<=2.3.2).
(+ some little obvious code improvement in sndrcv())
Please include it in TODO.
See also already closed #1276