Paulvancoller techtest submission#13
Open
ghost wants to merge 11 commits into
Open
Conversation
…olders and namespaces for simpler management.
… implement sanitized inputs.
… lookup function to easily fetch the VAT value.
…ention especially since this is a class library that will be used by other projects.
|
@seanogt, please review when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR submits Paul van Coller's (Cyberpro Consulting) Tech Test results.
It refactors the code into some better practices and implements Customer listing (with optional orders), as well as customer linking to orders.
Refactoring updates:
Issues / refactoring not done:
Additionally, since the Order Repository is marked as internal, one might guess that the original intention was for only the AnyCompany assembly to know about these objects, rendering Inversion of Control on these objects irrelevant.