Refactoring Tomasz Dobrowolski#10
Open
tomaszdobrowolski1 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of my code was to move the existing ADO.NET (legacy) logic out to prevent any bugs (leave what has been tested and works) and make it ready for replacement (by entity framework etc). Hence didn't spend time on making ADO.NET code pretty.
Interfaced everything and made it ready for DI (Dependency Injection)
potential tasks pending:
move connectionstrings to web.config /resource files
implement dependency injection
replace ADO.NET with entity Framework
add unit tests for service layer :
public bool PlaceOrder(Order order, int customerId)