Skip to content

Refactor core Ruby module API#89

Merged
andrii-balitskyi merged 7 commits intomainfrom
refactor-core-ruby-module-api
Aug 20, 2024
Merged

Refactor core Ruby module API#89
andrii-balitskyi merged 7 commits intomainfrom
refactor-core-ruby-module-api

Conversation

@andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Aug 9, 2024 •
edited
Loading

Closes #71

  • Rename Client to Http, use it in Seam module constructor and move factory methods to Seam
  • FIx tests
  • Allow accessing defaults with dot notation
  • Move lts_version method to Http class

@andrii-balitskyi andrii-balitskyi merged commit b3367f7 into main Aug 20, 2024
@andrii-balitskyi andrii-balitskyi deleted the refactor-core-ruby-module-api branch August 20, 2024 13:52
@andrii-balitskyi andrii-balitskyi mentioned this pull request Sep 18, 2024
Merged
@andrii-balitskyi andrii-balitskyi mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razor-x razor-x razor-x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor core Ruby module API

2 participants

@andrii-balitskyi @razor-x