Conversation
|
The default should be True. The RFC has it on True by default for the kernel for good reasons -- the FPU was enabled by default before and you will get hangs/crashes if you do not force the compiler to avoid FPU/SIMD instructions. |
|
Apologies, right - the FPU will be enabled by default and only disabled if one explicitly specifies |
|
I've fixed up the https://github.com/nspin/rust-sel4/tree/nspin/suggestion/fpu_flag After rebasing and incorporating this suggestion, this PR should be ready to merge. |
crates/sel4/src/invocations.rs
Outdated
| pub fn build(self) -> Self { | ||
| self | ||
| } |
There was a problem hiding this comment.
Shouldn't this be:
pub fn build(self) -> Word {
self.0
}There was a problem hiding this comment.
Corrected, right.
There was a problem hiding this comment.
I just can't test it locally - make run-tests fails with linking errors for the toolchain
JDuchniewicz
force-pushed
the
fpu_flag
branch
5 times, most recently
from
c35fbf5 to
1199223
Compare
| continue | ||
| vaddr = max(vaddr, seg['p_vaddr'] + seg['p_memsz']) | ||
| return vaddr | ||
| return vaddrender_elf.rsr |
There was a problem hiding this comment.
Seems this line was mistakenly changed.
There was a problem hiding this comment.
Removed, bashing my keyboard too quickly 😅
Signed-off-by: Jakub Duchniewicz <j.duchniewicz@unsw.edu.au>
6 participants
Allows for PDs to specify the
fpuflag to explicitly disable the FPU usage in them. By default it's set totrue.