Reject all matplotlib shorthand color notations in _is_color_like#584
Merged
Reject all matplotlib shorthand color notations in _is_color_like#584
Conversation
Fixes #211. Single-letter colors (b, g, r, …), CN cycle notation (C0, C1, …), tab: and xkcd: prefixed colors were accepted by _is_color_like, causing column or gene names that happen to match these shorthands to be interpreted as literal colors instead of data lookups. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
timtreis
changed the title
timtreis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
+ Coverage 76.30% 76.44% +0.14%
==========================================
Files 11 11
Lines 3254 3261 +7
Branches 756 759 +3
==========================================
+ Hits 2483 2493 +10
+ Misses 467 466 -1
+ Partials 304 302 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"b","r","g","C0", etc. were misinterpreted as literal matplotlib colors instead of being used for data-driven coloring._is_color_like()to reject all matplotlib shorthand notations: single-letter colors, CN cycle notation,tab:-prefixed, andxkcd:-prefixed colors."red","blue"), full hex ("#FF0000"), and RGB(A) tuples remain accepted.