Add basic structure for asv performance measurement#289
Add basic structure for asv performance measurement#289LucaMarconato merged 7 commits intoscverse:mainfrom
Conversation
|
Ah no the problem is not with mamba, but that we need to run asv in main first. I'll revert my commit. |
No problem is with lack of definition of release commit (it point to main, instead of commit hash). When you plan to do next release? I will create separate PR to improve release process and fix lack of this information. |
|
@Czaki I checked the code and it looks great to me! I have noticed that in a few places there seems to be some redundancy in some configuration that could lead to problems in the future if we are not careful when making changes. For instance I see that Python 3.11 is specified manually in Example checklist on how to add/edit benchmarks:
WDYT? |
|
Probably we will be doing a release of |
|
Could you check readme now? |
|
Looks great, thanks! |
Based on napari asv (https://asv.readthedocs.io/en/v0.6.1/) configuration, I have created initial configuration for this project.
Added benchmarks are only for adding structure. After review of the code, I'm not sure where I should start with benchmarks.