Respect quiet=True in DeseqStats.lfc_shrink#304
Merged
BorisMuzellec merged 1 commit intoscverse:mainfrom Sep 3, 2024
complextissue:main
Merged
Respect quiet=True in DeseqStats.lfc_shrink#304BorisMuzellec merged 1 commit intoscverse:mainfrom complextissue:main
BorisMuzellec merged 1 commit intoscverse:mainfrom
complextissue:main
Conversation
maltekuehl
requested review from
BorisMuzellec,
arthurPignetOwkin,
maikia and
umarteauowkin
as code owners
BorisMuzellec
approved these changes
Sep 3, 2024
Collaborator
BorisMuzellec
left a comment
BorisMuzellec
left a comment
There was a problem hiding this comment.
LGTM, thanks @maltekuehl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR implement?
Currently,
DeseqStats.lfc_shrinkdoes not respectself.quietwhen printingself.results_dfat the end of the method. This PR adds checks forself.quietfor the missing print statements.