Skip to content

Move scratch-blocks to GHA - #3118

Merged
delasare merged 9 commits into
developfrom
rd/ENG-18/move-to-gha
Oct 31, 2023
Merged

delasare merged 9 commits into
developfrom
rd/ENG-18/move-to-gha

Conversation

@delasare

@delasare delasare commented Oct 11, 2023 •

Copy link
Copy Markdown
Contributor

Resolves

https://scratchfoundation.atlassian.net/browse/ENG-18

  • Adds codeowners file
  • Adds nvmrc - bumps to Node v 18
  • Adds GHA workflow file
  • Uses github action for github pages.
  • Includes bump to Python 3

@delasare
delasare force-pushed the rd/ENG-18/move-to-gha branch from 09d7c23 to 50f4a16 Compare October 25, 2023 17:47
@delasare delasare changed the title Rd/eng 18/move to gha Move scratch-blocks to GHA Oct 25, 2023
@delasare
delasare marked this pull request as ready for review October 25, 2023 19:15
Ron de las Alas and others added 7 commits October 25, 2023 15:18
Port of RaspberryPiFoundation/blockly#2123 (by @gomercin)

Fix issues related to Python 3 compatibility

Port of RaspberryPiFoundation/blockly#2125 (by @gomercin)

Fix compatibility problems with Python 3's reduce(), filter() et al.

Fix Python 3 compatibility problems related to str encodings

Remove obsolete UnicodeEncodeError handling

@cwillisf cwillisf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, but the hard parts look good.
Thanks for taking care of such a complicated repo!

Comment thread .github/workflows/deploy.yml Outdated
Comment thread .github/workflows/deploy.yml Outdated
@delasare
delasare requested a review from cwillisf October 31, 2023 14:10

@cwillisf cwillisf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@delasare
delasare merged commit e72818d into develop Oct 31, 2023
github-actions Bot pushed a commit that referenced this pull request Oct 31, 2023
…ENG-18/move-to-gha

Move scratch-blocks to GHA
github-actions Bot pushed a commit to hsunli/scratch-blocks that referenced this pull request Nov 7, 2023
…tchfoundation/rd/ENG-18/move-to-gha

Move scratch-blocks to GHA
github-actions Bot pushed a commit to shijingwei/scratch-blocks that referenced this pull request Nov 17, 2023
…tchfoundation/rd/ENG-18/move-to-gha

Move scratch-blocks to GHA
github-actions Bot pushed a commit to jiafangtao/scratch-blocks that referenced this pull request Jan 8, 2024
…tchfoundation/rd/ENG-18/move-to-gha

Move scratch-blocks to GHA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants