Option to disable main fireball when ship is destroyed#7179
Open
Kestrellius wants to merge 1 commit into
Open
Conversation
wookieejedi
added
the
enhancement
wookieejedi
reviewed
Feb 13, 2026
| @@ -9785,30 +9792,30 @@ static void ship_dying_frame(object *objp, int ship_num) | |||
| polymodel *pm = model_get(sip->model_num); | |||
| shipp->end_death_time = timestamp((int) pm->core_radius); | |||
| } else { | |||
Member
There was a problem hiding this comment.
In order to minimize diffs, one possible method you may consider is to make just two else if conditionals. One for the else if (sip->disable_main_fireball) and a final else
wookieejedi
reviewed
Feb 13, 2026
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Code make sense, but had one suggestion for making cleaner diff
BMagnu
added
the
Waiting for Stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a boolean option to get rid of the main fireball when a ship blows up, to provide the ability to more easily avoid redundancy with the $Ship Death Effect that spawns at the same time. In all other cases, when I added particle hooks for ship explosion effects, I arranged it so that the relevant fireballs would be disabled if a valid particle effect was present; however, the $Ship Death Effect predated me and didn't have that behavior, so I couldn't add it.
I wish I could have handled this more cleanly, but I think this is the best option. I considered trying to do something with the $Explosion Animations field, but the list of animations defined there is multipurpose.