Add CLI for benchmark script#101
Merged
Merged
Conversation
Collaborator
|
@rschoene Please have a look. I am ok with this. |
rschoene
reviewed
Oct 5, 2020
Member
rschoene
left a comment
rschoene
left a comment
There was a problem hiding this comment.
That thing. Rest is okay with me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself modifying the benchmark script multiple times to only run a single benchmark or instrumenter or use another number of repetitions.
To make this easier I added a CLI that allows to change the behavior via parameters. Without any parameter given it behaves exactly as before. But now you can also do
./benchmark.py --test bm_baseline.py --instrumenter cTrace cProfile --loop-count 1e4 2e4 5e6I think it is simple, self-descriptive and flexible. I didn't include the option to change the number depending on the benchmark to keep it simple and as you can select a single benchmark I don't think it is required. By default it does use the pre-defined iterations per benchmark though.