Scala 2.12.4 upgrade + improve input type resolution#6
Closed
keithschulze wants to merge 2 commits intoscijava:masterfrom
Closed
Scala 2.12.4 upgrade + improve input type resolution#6keithschulze wants to merge 2 commits intoscijava:masterfrom
keithschulze wants to merge 2 commits intoscijava:masterfrom
Conversation
… to the correct type. Thus we no longer need boilerplatey `.asInstanceOf` casts to use input parameters.
Member
|
I assume this was closed in favor of #7? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Scala to latest stable version.
Also, automatically cast input parameters to correct type to reduce boilerplate on developers. Previously, running the following with blob.gif open would give a ScriptException:
This is because input parameters are injected into the script Bindings (i.e., Map<String, Object>), where type information is lost. This could be fixed by explicitly casting img to Dataset e.g.,
img.asInstanceOf[Dataset].getChannels. After this change, this is no longer necessary since we cast for input parameters to correct type automatically (i.e., through callback in ScriptModule). So, the following works: