Repository navigation
[wip] [vk] Every choice by driver is a line of the extension bans - #2591
Draft
DraChimeraVee wants to merge 10 commits into
Draft
DraChimeraVee wants to merge 10 commits into
DraChimeraVee wants to merge 10 commits into
Conversation
added 9 commits
November 20, 2026 00:44
A choice the renderer made by comparing a vendor or a driver had no place in the table, whose lines only turn a key off. A prefer line names the drivers that take a way, with the measure that showed it; vk_prefer asks, and vulkan_ban_ignore goes over it. Change-Id: Iac8def1ca16ad0176dd48b9877ffc093dfe4015e Signed-off-by: AF52 <AF52@reden-emu.dev>
device.c took the capture where the GPU's vendor was NVIDIA or AMD. The five drivers of those vendors are prefer lines now, each with its measure, the integrated GPU's on AMD's own driver among them; a test holds the lines against the old rule for every driver. Change-Id: I5c12807c3393e8078dba21ad08e70aec616b464e Signed-off-by: AF52 <AF52@reden-emu.dev>
render.c skipped the pass by comparing the driver with NVIDIA's. That driver is a prefer line on Location now, with Eden's rule and the two games' cost as its source. Change-Id: I7a87a92d06008ca7d17cf06e5732b21196c949f7 Signed-off-by: AF52 <AF52@reden-emu.dev>
device.c took the pairs by comparing the driver with RADV. RADV is a prefer line on OpGroupNonUniformShuffleXor now, with its bench's 9.7% as the measure. Change-Id: I33cc29e4b8b3dbb9df261892637b446ba2c98ed7 Signed-off-by: AF52 <AF52@reden-emu.dev>
cmd.c took cached memory by comparing the driver with Intel's Mesa one. ANV is a prefer line on VK_MEMORY_PROPERTY_HOST_CACHED_BIT now. Change-Id: I4bdeb875ab0ea84b7c8fbd71cf32cd611a243027 Signed-off-by: AF52 <AF52@reden-emu.dev>
pipeline.c turned the windows off by comparing the driver with lavapipe. The line on maxPushConstantsSize holds it now, and the log says it with its source as any ban. Change-Id: Ie03e667aa9ce0ad62dc9dc80764f484d89ac3d7d Signed-off-by: AF52 <AF52@reden-emu.dev>
uma.c listed RADV, AMDVLK and AMD's Linux driver in a switch. They are off lines on the host pointer handle type now, which uma_copies goes over as before. Change-Id: Ibf46ab89883ee192beaad4de34defab6d824f529 Signed-off-by: AF52 <AF52@reden-emu.dev>
device.c compared the driver with NVIDIA's under an #ifdef for Windows. The line on vkCreateGraphicsPipelines names NVIDIA's driver on every system but Windows. Change-Id: I04bb29e451cb88b6b2a30e3adf98fba9687e0736 Signed-off-by: AF52 <AF52@reden-emu.dev>
The interlock's choice sat in device.c by vendor, where nobody reading the table saw it. runtime_architecture now fails on such a comparison in src/ with its file and line, but for the listed ones that choose no way by driver. Change-Id: Iba9dc211ea337c71dce505a2b6c1abbe1497125f Signed-off-by: AF52 <AF52@reden-emu.dev>
Four comment lines of this branch were longer than the files' limit. Change-Id: Iac9278c20f25ae3e3576978c6ac9ae23d6362cb1 Signed-off-by: AF52 <AF52@reden-emu.dev>
DraChimeraVee
force-pushed
the
dravee/vk/bans-in-table
branch
from
November 20, 2026 10:20
b9a2d85 to
6341d0b
Compare
|
Builds of 6341d0b, kept until 2027-02-18:
Amberlith v1.0.0: 923 passed, 0 failed, 2 skipped, 0 crashed; Amberlith v1.0.0's APK: 854 passed, 7 failed, 0 skipped, 0 crashed: every case of the baseline passes Not built: appimage-cross (skipped) |
DraChimeraVee
force-pushed
the
dravee/vk/bans-in-table
branch
from
November 20, 2026 19:35
6341d0b to
6c919d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renderer chose seven ways by comparing a driver or a vendor in the code, where nobody reading the ban table saw them. They are lines of
extension_bans.txtnow, and a test refuses a new comparison outside the table's reader. No device changes what it does (see Notes for the one exception).preferaction: a way only the drivers listed take, asked withvk_prefer, with the same source, retest, checked and override fields;vulkan_ban_ignoregoes over it.runtime_architecturefails on aVK_DRIVER_ID_*, a vendor, driver or device ID compared, or a device name matched insrc/, with the file, the line and what to do.DRIVER_CHOICESlists the comparisons that choose no way by driver: a pipeline cache's identity,gpu_pstate's interface by vendor, the GPU family the ASTC encoder and the UI's blend are written for, the GUI's driver packages.Notes:
Locationfor the driver's own interpolation): say if another reads better.Testing:
vk_extension_bansholds each line against the rule the code had, for every driver the table names on every system; the new architecture rule gives 13 errors on main'ssrc/and none here.