api: resolve patchset summary by slug as fallback - #499
Open
zraza-xlnx wants to merge 1 commit into
Open
zraza-xlnx wants to merge 1 commit into
zraza-xlnx wants to merge 1 commit into
Conversation
Contributor
Author
|
Reviewed by @pieterj-xilinx and @alexaust-xlnx internally. |
zraza-xlnx
marked this pull request as draft
September 14, 2026 11:45
zraza-xlnx
marked this pull request as ready for review
September 14, 2026 12:05
The GET /api/patchset summary handler only looked up patchsets by numeric id or message-id. Forge ingested patchsets are addressed by slug (for example reponame-79), so the web UI's summary requests for those patchsets fell through to the message-id lookup, matched nothing, and returned 404. Chain the non numeric lookups by result: try message-id first, then fall back to slug when the message-id lookup finds nothing. This mirrors the branching already used by the patchset details handler. Signed-off-by: Zuhair Hasan Raza <ZuhairHasan.Raza@amd.com>
zraza-xlnx
force-pushed
the
user/zraza/api-patchset-summary-by-slug
branch
from
September 18, 2026 09:04
ea697a9 to
ec4a4db
Compare
Sashiko review — v2Commit 1/1 —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GET /api/patchset summary handler only looked up patchsets by numeric id or message-id. Forge ingested patchsets are addressed by slug (for example reponame-79), so the web UI's summary requests for those patchsets fell through to the message-id lookup, matched nothing, and returned 404.
UI links reviews by slug, but the API never resolved slugs. This PR adds that fallback so slug links stop 404 error.
sashiko/static/index.html
Line 1967 in 39f6ce9
Chain the non numeric lookups by result: try message-id first, then fall back to slug when the message-id lookup finds nothing. This mirrors the branching already used by the patchset details handler.
Regression test results
id=linux-next-725(reponame-prnum)id=42selects numeric patchset 42This change is backward compatible.