prompts: add Sashiko review profile - #455
Open
OllieinCanada wants to merge 3 commits into
Open
OllieinCanada wants to merge 3 commits into
OllieinCanada wants to merge 3 commits into
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
OllieinCanada
marked this pull request as ready for review
August 25, 2026 04:37
added 2 commits
September 10, 2026 14:24
Resolve the current conflict with the independently validated tree. Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
Keep the Sashiko completeness test at a merge-friendly anchor. Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boundaries;
project-context.mdguidance through the active workflow promptrenderer used by review stages;
with no model or external-service calls.
The profile is not enabled automatically. It can be selected directly with a
local
--prompts third_party/prompts/sashikoinvocation. PR #447 supplies theseparate daemon configuration seam.
Compatibility and scope
Existing profiles without
project-context.mdretain their prior generatedsystem-prompt bytes and provider requests. The change does not alter forge or
NNTP ingestion, Git operations, database schemas, AI-provider implementations,
review publication, or multi-repository behavior.
The guidance focuses on concrete Sashiko invariants: Tokio task and channel
lifecycle, Git/worktree ownership, subprocess cleanup, webhook authentication,
repository URL handling, persistence and retry idempotence, provider failures,
token budgets, secret redaction, and configuration compatibility.
Dependency and rollout
PR #467 must land before or with this PR for reliable upgrades of an already
extracted bundled prompt tree. Without #467, an existing completion marker for
the unchanged bundle revision can leave that installation without the new
sashiko/directory. Fresh installations and direct source-tree--promptsusage are not affected.
PR #447 is required only for daemon selection of this profile; local profile
loading and the deterministic tests do not depend on it.
Deterministic tests
The new tests verify the complete bundled profile, exact no-context compatibility,
unchanged recording-provider requests for existing profiles, and Sashiko guidance
reaching actual workflow-stage provider requests.
Exact-head validation against upstream
39f6ce95c797bb40023247916a8b16d0f4aaf0da:d045226e9965ddb8a231f0524df4cfac8444d773make check-pr: completed with 531 passed, 1 failed, and1 ignored; the sole failure was the unchanged upstream timing test
deadline_budget_credit_wait_deduplicates_overlapping_sleeps, which alsofailed on exact current
main, so this is not evidence of a prompts: add Sashiko review profile #455 regressiongit diff --check origin/main...HEAD: passedand Rust unit tests)
Independent validation record
A separate, non-PR evidence branch records the combined deterministic checks,
exact identities, limitations, and reproduction notes without adding audit
artifacts to this focused change:
evidence/sashiko-self-review-2026-09-11No live model review or historical-PR quality benchmark was run. The evidence
therefore supports the deterministic implementation path only; it does not
establish review precision, recall, or production-model reliability.