chore: dependency upgrades#33
Conversation
josephineweidner
left a comment
josephineweidner
left a comment
There was a problem hiding this comment.
@joshmcclain I feel like I've spent too long trying to get this up and running properly. Can we pair on this during our 1-1 on Monday?
| gem 'bootsnap', '>= 1.4.2', require: false | ||
| gem 'activeadmin' | ||
| gem 'devise', github: 'heartcombo/devise', branch: 'ca-omniauth-2' | ||
| gem 'devise' |
There was a problem hiding this comment.
Looks like the ca-omniauth-2 branch doesn't exist anymore and was merged into main for versions 4.8 and later heartcombo/devise#5327 (comment)
| PLATFORMS | ||
| ruby | ||
| arm64-darwin-23 | ||
| x86_64-linux |
There was a problem hiding this comment.
🤔 not sure this change is ok but bundle lock --add-platform ruby didn't work as expected
There was a problem hiding this comment.
@joshmcclain this is the main concern. Adding x86_64-linux allows the Heroku integration tests to pass. Is that sufficient?
There was a problem hiding this comment.
Yep that should be sufficient. There's some history at play here: older versions of bundler used to just include ruby as the default fallback platform, but newer versions started to list the actual platform targets explicitly. So the way you have it should be fine. It's the more up-to-date way of specifying platforms in this file.
There was a problem hiding this comment.
(And I see below that you bundled with 2.4.22, so this is expected)
There was a problem hiding this comment.
Oh great! Alicia and I were wondering about this on Cocoon, too.
|
@josephineweidner yes absolutely! Can you qualify "properly"? Tests in CI look okay -- is there an error you're hitting locally? |
|
@joshmcclain yes! Responded inline in the comment above! |
|
@joshmcclain this should be ready for approval and merge in that case! Thanks for your review 🙏 |
2 participants
These changes were necessary to get this repo running on my Mac M1. This PR also adds the
active_model_serializersgem (necessary for #32).Will leave comments throughout and mark as draft until I'm confident in this being merged