Implement parsing SQLAlchemy objects#94
Merged
samuelcolvin merged 8 commits intosamuelcolvin:masterfrom Sep 5, 2021
aliereno:master
Merged
Implement parsing SQLAlchemy objects#94samuelcolvin merged 8 commits intosamuelcolvin:masterfrom aliereno:master
samuelcolvin merged 8 commits intosamuelcolvin:masterfrom
aliereno:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 99.60% 99.61%
=======================================
Files 7 7
Lines 506 513 +7
Branches 71 71
=======================================
+ Hits 504 511 +7
Misses 2 2
Continue to review full report at Codecov.
|
alexmojaki
reviewed
Sep 4, 2021
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
alexmojaki
reviewed
Sep 4, 2021
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
Contributor
|
LGTM! |
samuelcolvin
reviewed
Sep 5, 2021
Owner
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
this looks great, thank you so much.
Just one small thing to fix.
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
samuelcolvin
reviewed
Sep 5, 2021
Owner
samuelcolvin
left a comment
samuelcolvin
left a comment
There was a problem hiding this comment.
one more thing I noticed, I'll add this, then merge.
Owner
|
Thanks so much for your contribution @aliereno, this will be really useful. I'll create a new release soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I saw #72 issue and wanted to contribute.