Trying to fix tests on windows

[alexmojaki]

No description provided.

[codecov]

Codecov Report

Merging #93 (453eabd) into master (66eaa80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files           7        7           
  Lines         506      513    +7     
  Branches       71       71           
=======================================
+ Hits          504      511    +7     
  Misses          2        2           

Impacted Files	Coverage Δ
devtools/debug.py	100.00% <100.00%> (ø)
devtools/prettier.py	100.00% <0.00%> (ø)
devtools/utils.py	96.29% <0.00%> (+0.74%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66eaa80...453eabd. Read the comment docs.

[samuelcolvin]

otherwise this looks great.

[samuelcolvin]

just noticed some tests are failing on windows, but CI is passing. We had the same problem on pydantic and discovered that CI setup like

    - name: test with extras
      run: |
        make test
        coverage xml

when run with windows doesn't detect a failure in the first command.

I'll try to fix or skip these tests since they aren't really related to what you were fixing here (easier to fix here than on main since you've resolved a bunch of problems with windows 🙏)

[alexmojaki]

There's an actual failure in executing on Windows 3.9+. This is annoying and worrying. I've never seen executing affected by the OS. Any idea why it would matter? Isn't the bytecode the same?

[samuelcolvin]

Yes, just saw it.

I have absolutely no idea why this combination would fail. I also don't have a windows machine to test with.

Shall I leave this with you? I'm happy to skip or xfail this test on these os/version combinationd, but I understand you might want to look into it.

[alexmojaki]

I definitely need to investigate but for now please just xfail it.

[samuelcolvin]

thanks so much.