Add extra bgzip error checking - #2059
Merged
Merged
Conversation
jkbonfield
reviewed
Jul 30, 2026
jkbonfield
left a comment
jkbonfield
left a comment
Contributor
There was a problem hiding this comment.
All looks fine bar a missing newline.
| size_t len = strlen(argv[optind]); | ||
| char *name = hts_malloc_ps(sizeof(*name), len, 5); | ||
| if (!name) | ||
| error("[bgzip] Couldn't allocate space for output file name"); |
Contributor
There was a problem hiding this comment.
error() requires a newline, unlike hts_log_error. Maybe it should be changed, but easier to to fix it here.
Member
Author
There was a problem hiding this comment.
Missing newline should now be present.
Add more error checking to the bgzip application, mostly for memory allocations, but it will also more directly report read failures (previously these relied on hclose() returning an error after a read failure). For brevity, reporting is done using the existing error() function, which is now also annotated with HTS_NORETURN. Changes an instance of strcpy()/strcat() to the less controversial snprintf(). Signed-off-by: Rob Davies <rmd+git@sanger.ac.uk>
daviesrob
force-pushed
the
bgzip-error-checks
branch
from
July 30, 2026 15:56
ddca391 to
77f0036
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more error checking to the bgzip application, mostly for memory allocations, but it will also more directly report read failures (previously these relied on
hclose()returning an error after a read failure). For brevity, reporting is done using the existingerror()function, which is now also annotated withHTS_NORETURN.Changes an instance of
strcpy()/strcat()to the less controversialsnprintf().So far I've resisted splitting the rather large
main()function up, but it is quite tempting.