Skip to content

Develop - warning fixes, translations, root permission fixes - #989

Merged
sameerasw merged 9 commits into
mainfrom
develop
Sep 13, 2026
Merged

sameerasw merged 9 commits into
mainfrom
develop

Conversation

@sameerasw

Copy link
Copy Markdown
Owner

This pull request includes a version update to 18.0, various improvements to compatibility with newer Android SDKs, refactoring for better type safety and code clarity, and updates to feature permission checks and UI transitions. The most important changes are summarized below.


Version Update:

  • Bumped versionCode to 63 and versionName to "18.0" in app/build.gradle.kts, and incremented the whatsNewCounter.

Android SDK Compatibility and Refactoring:

  • Updated AOD (Always On Display) detection logic in both InputEventListenerService and ButtonRemapHandler to use Display.STATE_DOZE and Display.STATE_DOZE_SUSPEND for Android R and above, with proper fallbacks and deprecation suppressions for earlier SDKs. [1] [2]
  • Improved handling of task IDs and deprecated fields in CombinedActionExecutor to ensure compatibility with Android Q+ and earlier.
  • Replaced deprecated getSystemService usage with ContextCompat.getSystemService for Vibrator in ScreenOffAccessibilityService.
  • Updated activity transition logic in YourAndroidActivity to use overrideActivityTransition for Android Upside Down Cake and fallback to deprecated methods for earlier versions.

Type Safety and Code Quality:

  • Improved type safety in SettingsRepository by using a proper TypeToken for JSON deserialization instead of unchecked casts.
  • Refactored feature permission checks for "Screen locked security" to use ShellUtils.hasPermission for consistency and maintainability. [1] [2]
  • Refactored permissionKeys in FeatureRegistry to be an overridden property, improving clarity and logic separation.
  • Removed unused or redundant variables and improved null safety and call chaining in several places (e.g., media controller handling in StatusGlanceTouchHandler and CombinedActionExecutor). [1] [2] [3]

UI and Sheet Handling:

  • Removed unnecessary sheetState parameters from several bottom sheet composables for simplification. [1] [2] [3] [4] [5] [6] [7] [8]

Minor Improvements:

  • Added missing imports and suppressed deprecation warnings where appropriate for better code hygiene. [1] [2] [3] [4]
  • Ensured correct animation transitions and removed redundant code in YourAndroidActivity.

These changes collectively improve the stability, maintainability, and compatibility of the codebase with the latest Android versions.

@sameerasw sameerasw self-assigned this Sep 13, 2026
@sameerasw sameerasw added bug Something isn't working enhancement New feature or request translations For Translations and related tasks labels Sep 13, 2026
@sameerasw
sameerasw merged commit 014bb22 into main Sep 13, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Essentials Progress Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request translations For Translations and related tasks

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants