Skip to content

feat: move info buttons into nav bar header#92

Merged
samdaw13 merged 1 commit intomainfrom
feat/info-button-in-nav-bar
Mar 6, 2026
Merged

feat: move info buttons into nav bar header#92
samdaw13 merged 1 commit intomainfrom
feat/info-button-in-nav-bar

Conversation

@samdaw13
Copy link
Copy Markdown
Owner

@samdaw13 samdaw13 commented Mar 6, 2026

Summary

  • Removes the inline info IconButton from BreakCipher, machine Settings, and Keyboard screen bodies
  • Uses navigation.setOptions({ headerRight }) (BreakCipher) and useFocusEffect + navigation.getParent()?.setOptions (machine stack screens) to place the info icon in the top-right of the nav bar on each screen
  • Updates all affected test mocks to include getParent and useFocusEffect

Test plan

  • Info icon appears in the top-right of the nav bar on Break a cipher, Enigma machine settings, and Keyboard screens
  • Tapping the info icon opens the correct InfoSidebar for each screen
  • Navigating between Settings and Keyboard correctly swaps the info button content (settings info vs keyboard info)
  • All 119 existing tests pass

🤖 Generated with Claude Code

Replaces inline IconButton info buttons in BreakCipher, machine Settings,
and Keyboard with headerRight options set via React Navigation, so the
info icon appears consistently in the top-right of the nav bar on each screen.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@samdaw13 samdaw13 enabled auto-merge March 6, 2026 19:20
@samdaw13 samdaw13 merged commit 5da7a87 into main Mar 6, 2026
2 checks passed
@samdaw13 samdaw13 deleted the feat/info-button-in-nav-bar branch March 6, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant