Skip to content

Add malloc size check - #93

Merged
saitoha merged 1 commit into
saitoha:masterfrom
knok:cve-2018-19756
Dec 14, 2019
Merged

saitoha merged 1 commit into
saitoha:masterfrom
knok:cve-2018-19756

Conversation

@knok

@knok knok commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

#80 caused by zero-size malloc.

@saitoha
saitoha self-requested a review July 12, 2019 14:28
@knok

knok commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

The original code seems size check in rpl_malloc:
https://github.com/saitoha/libsixel/blob/master/converters/malloc_stub.c#L43
and if size equals 0, try to allocate 1 byte instead of 0,but this problem seems to access over this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants