Handle optional tensorboard dependency in timers#16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| from .transformer_layer import ParallelTransformerLayer | ||
|
|
||
| __all__ = ["ParallelTransformerLayer"] |
There was a problem hiding this comment.
Fix broken re-export of ParallelTransformerLayer
The new alias module imports ParallelTransformerLayer from transformer_layer, but that file only defines TransformerLayer. Importing megatron.core.transformer.parallel_transformer_layer therefore raises ImportError before any tests run. The same mistake appears in the other parallel_* wrappers (parallel_transformer_block, parallel_attention, parallel_mlp), so none of these modules can be imported. The aliases need to import the real classes (e.g. TransformerLayer as ParallelTransformerLayer) or reference the correct module under megatron.model.transformer.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e857249054832abaafff0491ff7eab