Repository navigation
fix(issue #92): clarify overnight-only HRV setting and manual HRV reading - #95
Merged
ryanbr merged 1 commit intoJul 9, 2026
Merged
Conversation
…RV reading - Update Settings → Strap → "Overnight only" description to explain that continuous background HRV capture (including daytime naps) is paused outside the overnight window - Direct users to the "Take an HRV reading" button on the Live screen for on-demand daytime HRV readings - This is a baby-step fix: clarifies existing behavior rather than changing the overnight-only window logic itself
digitalerdude
pushed a commit
to digitalerdude/noop
that referenced
this pull request
Jul 9, 2026
Mirror the Android copy clarification (merged ryanbr#95) onto the shared iOS/macOS SettingsView so both platforms explain the 'Overnight only' continuous-HRV setting the same way: continuous background HRV capture (incl. daytime naps) is paused outside the quiet-hours window, and for an on-demand daytime reading the user should use the 'Take an HRV reading' button on the Live screen. Copy-only, verbatim match to the Android string now on main. No behaviour change (the overnight-window logic + the manual-snapshot realtime bypass are unchanged); verified both referenced facts against the code — the Live-screen button exists with that exact label, and the snapshot arms the R-R stream via screenWantsRealtime regardless of the overnight gate. Addresses the iOS half of ryanbr#92.
DX23876
pushed a commit
to DX23876/noop
that referenced
this pull request
Jul 22, 2026
…ernight-only fix(issue ryanbr#92): clarify overnight-only HRV setting and manual HRV reading
DX23876
pushed a commit
to DX23876/noop
that referenced
this pull request
Jul 22, 2026
Mirror the Android copy clarification (merged ryanbr#95) onto the shared iOS/macOS SettingsView so both platforms explain the 'Overnight only' continuous-HRV setting the same way: continuous background HRV capture (incl. daytime naps) is paused outside the quiet-hours window, and for an on-demand daytime reading the user should use the 'Take an HRV reading' button on the Live screen. Copy-only, verbatim match to the Android string now on main. No behaviour change (the overnight-window logic + the manual-snapshot realtime bypass are unchanged); verified both referenced facts against the code — the Live-screen button exists with that exact label, and the snapshot arms the R-R stream via screenWantsRealtime regardless of the overnight gate. Addresses the iOS half of ryanbr#92.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the "Overnight only" setting for Continuous HRV capture in Settings → Strap.
Changes
Rationale
This is a baby-step fix: clarifies existing behavior rather than changing the overnight-only window logic itself. The issue (#92) reports that when "Overnight only" is enabled, daytime naps aren't tracked because the continuous HRV stream only runs during the overnight window (22:00-07:00 by default). The manual HRV Snapshot feature (accessible from the Live screen) works independently of this setting since it uses the screen-wants-realtime path that bypasses the overnight window gate.
Testing