Repository navigation
Point links to the fork + remove donations / Support section - #9
Merged
Merged
Conversation
added 3 commits
July 7, 2026 15:43
The active repo is the fork now, so repoint the user-facing/functional github links (the update check already pointed at ryanbr/noop): Code (compiles; testcentre tests 108 pass): - Settings → About "Project home & source" link (Android; iOS was already ryanbr). - Bug-report "issues/new" URL + its tests/comments (Android + iOS). - Donation link (Android + iOS) → ryanbr/noop/wiki/Donations. Docs: README badges/links (releases, stars, wiki/FAQ, issues, clone, star-history), docs/IOS.md + BUILD.md + CONTRIBUTING.md release links, docs/SAFEGUARDS.md operational gh command, and altstore-source.json owner (host/path only — asset filenames untouched). Deliberately LEFT as-is: the `NoopApplication` class name; provenance/credit comments (PR #600, #569, #554, #1029, "reimplemented under NoopApp"); historical changelog entries (AppChangelog, CHANGELOG.md, docs/releases/); and the `Copyright NoopApp` / PolyForm license attribution.
The fork doesn't solicit donations, so remove the donation nudge and the Support screen entirely. Deleted: - Android: ui/DonationNudge.kt, ui/SupportScreen.kt - iOS/macOS: Screens/SupportView.swift, Screens/DonationNudgeCard.swift, System/QRCode.swift, System/WiggleEffect.swift (both were used ONLY by the support UI); dropped the donations array + CryptoAddress from System/ProjectInfo.swift (kept project identity/attribution). - docs/DONATIONS.md, Tools/update-donation-stats.sh, .github/FUNDING.yml (Sponsor button). Removed all call sites (so it still compiles): - Android: Destination.Support route + enum + drawer entry (AppRoot); DonationNudgeCard(), the Support heart button, the SupportRow card, and the onSupport plumbing (TodayScreen). - iOS: NavItem.support (RootView), the heart→Support sheet (LiquidTodayView), DonationNudgeCard() + Support sheet/toolbar/supportRow (TodayView), and the "Support" MoreRow (StrandiOS/RootTabView). - README + docs/ANDROID.md + docs/FEATURES.md: the "Keeping NOOP alive"/"Support (optional)" sections, badge, blurb, nav link, TOC/table entries, and DONATIONS.md links. Left as-is: historical changelog (AppChangelog, CHANGELOG.md, docs/releases) and the docs/SAFEGUARDS.md suspension narrative + "never paste crypto addresses in comments" compliance note. Verified: Android compileFullDebugKotlin BUILD SUCCESSFUL; zero dangling references to any deleted symbol across the whole repo (Swift CI-gated).
CHANGELOG.md is stale (stops at 7.9.0); the maintained per-version changelog is docs/releases/vX.Y.Z.md (current through v8.2.2). So the release build now uses docs/releases/<TAG>.md as the GitHub release body (+ a downloads footer), instead of the boilerplate. If that file is missing it emits a ::warning:: and falls back to a placeholder, so a forgotten changelog is noticed rather than silent. Flow: write docs/releases/v<NEW>.md first, then run the release workflow → the release carries it. (The in-app "What's New" / AppChangelog is still a separate manual edit — it can't be derived from a release, and its CURRENT_VERSION is decoupled from the marketing version.)
ryanbr
pushed a commit
that referenced
this pull request
Jul 7, 2026
…to the notes Each release's GitHub body is now: the curated docs/releases/<TAG>.md notes + GitHub's auto-generated "What's Changed" breakdown (every merged PR since the previous RELEASE, with authors/links + New Contributors + full-changelog compare link) + the downloads footer. Uses the generate-notes REST API (deterministic; not dependent on gh flag-combining) diffed from the most recent NON-prerelease release (so testing-latest snapshots are ignored). Skipped on the very first release (no prior tag would diff to repo start). Best-effort — a failure is ignored. Verified: the API returns the PR list (#1..#9); first-release PREV detection returns empty as expected.
DX23876
referenced
this pull request
in DX23876/noop
Jul 22, 2026
Point links to the fork + remove donations / Support section
DX23876
referenced
this pull request
in DX23876/noop
Jul 22, 2026
…to the notes Each release's GitHub body is now: the curated docs/releases/<TAG>.md notes + GitHub's auto-generated "What's Changed" breakdown (every merged PR since the previous RELEASE, with authors/links + New Contributors + full-changelog compare link) + the downloads footer. Uses the generate-notes REST API (deterministic; not dependent on gh flag-combining) diffed from the most recent NON-prerelease release (so testing-latest snapshots are ignored). Skipped on the very first release (no prior tag would diff to repo start). Best-effort — a failure is ignored. Verified: the API returns the PR list (#1..#9); first-release PREV detection returns empty as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related cleanups for the fork:
87fd7861— point functional GitHub links from upstreamNoopApp/noopto theryanbr/noopfork (project-home, bug-report, README/docs, AltStore owner). Left provenance/credits, historical changelog, and theNoopAppcopyright/license.d7d4e4a9— remove donations + the "Support NOOP" section entirely (both platforms): the Today nudge card, the Support screen, the heart button, nav entries, README/docs support sections,docs/DONATIONS.md,Tools/update-donation-stats.sh, and.github/FUNDING.yml. Kept historical changelog.Verification
Android
compileFullDebugKotlinBUILD SUCCESSFUL; zero dangling references to any deleted symbol across the whole repo (incl. StrandiOS). The Swift side (deleted whole files + call sites, incl.StrandiOS/RootTabView) is validated by the CI iOS + macOS build jobs.