Skip to content

Android auto-detect: read HR over the active-strap union, not hardcoded my-whoop (#767) #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbr merged 1 commit into from
Jul 24, 2026
Merged

Android auto-detect: read HR over the active-strap union, not hardcoded my-whoop (#767) #777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/app/src/main/java/com/noop/ui/AutoWorkoutNudge.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ private suspend fun autoDetectCandidate(
val fromSec = nowSec - AUTO_DETECT_DAYS_BACK * 86_400L
val repo = viewModel.repo

val hr = repo.hrSamples(AUTO_DETECT_DEVICE, fromSec, nowSec, limit = 200_000)
// #767/#717: read HR over the ACTIVE-strap UNION, not the hardcoded "my-whoop" id. A live-BLE strap
// banks its raw under its OWN fresh id ("whoop-<uuid>", #908), so a read pinned to "my-whoop" finds
// NOTHING and auto-detect goes silent — even though sleep/charge (which read the union) keep working.
// Mirrors iOS Repository.autoDetectCandidate(), which reads the hrSamples(from:to:) union.
val hr = repo.hrSamplesUnion(viewModel.deviceId, fromSec, nowSec, limit = 200_000)
if (hr.size < 2) return null

// Resting HR: most recent nightly RHR in history, else the detector's own default (60). Byte-faithful
Expand Down
Loading