Repository navigation
i18n_audit: trace val-backed accessibility copy (#571) - #739
Merged
Merged
Conversation
kavemang
marked this pull request as ready for review
July 23, 2026 06:03
simoncad7
pushed a commit
to simoncad7/noop
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #571.
What changed
contentDescription = namereference to the nearest lexically visibleval name = ...initializer.CoupledScreenshape, parameters, sibling scopes, local shadowing, statement bounds, and multiline concatenation.CoupledScreen.kt.Why
#581 taught the Android audit to see literals assigned directly inside a
semantics {}lambda, but it still saw no literal when a local variable carried the copy:This adds deliberately narrow lexical flow for that remaining #571 case. Pass-through parameters, arbitrary expressions, declarations in sibling scopes, and shadowed outer values are not followed.
Validation
cd Tools && python3 -m unittest test_i18n_audit -v— 34/34 passedpython3 Tools/i18n_audit.py --ci origin/main— passed; Android baseline 213, Apple baseline 64git diff --check— passed