Repository navigation
Refactor Health pure helper logic - #712
Merged
Merged
Conversation
DX23876
pushed a commit
to DX23876/noop
that referenced
this pull request
Jul 22, 2026
…-logic Refactor Health pure helper logic
simoncad7
pushed a commit
to simoncad7/noop
that referenced
this pull request
Aug 17, 2026
…-logic Refactor Health pure helper logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HealthLiveHrLogic.kt.HealthVitalDetailLogic.kt.HealthVitalsLogic.kt.HealthScreen.ktfocused on Compose UI wiring; no behavior change intended.Part of the incremental code-quality split discussed in #665. This is a Phase-1 pure-helper extraction only; UI/composable clusters remain in
HealthScreen.kt.Verification
JAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ANDROID_HOME=$HOME/Library/Android/sdk ./gradlew :app:compileFullDebugKotlinJAVA_HOME=/opt/homebrew/opt/openjdk@21/libexec/openjdk.jdk/Contents/Home ANDROID_HOME=$HOME/Library/Android/sdk ./gradlew :app:testFullDebugUnitTest --tests 'com.noop.ui.VitalRangeGatingTest' --tests 'com.noop.ui.VitalReadingsTableTest' --tests 'com.noop.ui.StepsReadingsMergeTest' --tests 'com.noop.ui.LiveHrSamplingTest' --tests 'com.noop.ui.HrvSnapshotHelpersTest':app:testDemoDebugUnitTest