Repository navigation
Steps calibration: replace the manual slider with a stepper (#698) - #704
Merged
ryanbr merged 1 commit intoJul 22, 2026
Merged
Conversation
The manual coefficient override used a Slider spanning 0..stepperMax (at least 0..100), so a real-world value like 1.2-1.4 sat in a handful of drag pixels and was practically undraggable. Replaced it with a StepperField (0.1 per tap), the same control the Profile card already uses for age/weight/height. Nudges start from whichever value is currently effective (the auto fit, until first overridden), so reaching a nearby value like 1.2 from an auto-fitted 1.4 is two taps. Stepping all the way down to 0 still returns to auto-fit, matching the old "drag to far left" behaviour. Dropped the now-unused "Auto"/"High" slider-endpoint strings from all five locale catalogs.
digitalerdude
marked this pull request as ready for review
July 21, 2026 14:44
DX23876
pushed a commit
to DX23876/noop
that referenced
this pull request
Jul 22, 2026
…tion-textfield Steps calibration: replace the manual slider with a stepper (ryanbr#698)
simoncad7
pushed a commit
to simoncad7/noop
that referenced
this pull request
Aug 17, 2026
…tion-textfield Steps calibration: replace the manual slider with a stepper (ryanbr#698)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698.
Problem
The manual steps-coefficient override (Settings → Profile → "Steps estimate" → Adjust manually) used a
Sliderspanning0..stepperMax, wherestepperMaxis at least 100 (maxOf(autoFit, manual, 50.0) * 2). Real-world coefficients sit around 1-2 (the reporter's auto-fit was 1.4), so that whole usable range was compressed into a handful of drag pixels — landing on a specific value like 1.2 instead of 1.3 or 1.5 was essentially impossible by touch.Fix
Replaced the slider with a
StepperField— the same shared component the Profile card already uses for age/weight/height (-/+buttons + a numeric readout), so this matches an established, already-accessible pattern instead of inventing a new one.draftManual,onCommit, the 0.5 commit-rounding) is no longer needed and is removed.l10n_steps_calibration_screen_auto_c614ba7c/..._high_...) from all five locale catalogs (en/de/es/fr/zh) — confirmed no other references first.Scope
Pure Android/Kotlin UI fix, no analytics/formula/stored-value change (
ProfileStore.stepsManualCoefficientkeeps the exact same meaning and persistence, just written by a stepper instead of a slider) — no iOS twin needed for this.Testing
./gradlew compileFullDebugKotlin✓ (JDK 17 via Homebrew;android.ymlis disabled so this is local-only for now)./gradlew testFullDebugUnitTest --tests "com.noop.ui.*"✓, all existing tests still passpython3 Tools/i18n_audit.py✓ — no new hardcoded-literal or missing-translation findings from this diff; the string removals leave zero gaps across de/es/fr/zh