Repository navigation
Conversation
…ate) app-build.yml was compile-only, so the app-target unit tests (StrandTests — backfill-continuation, scheduled-report/strain-target policy, the extended- battery formatter twin, etc.) never ran anywhere: swift-packages can't reach them and this was build-only. Add a macOS-only test step (StrandTests is hosted in the macOS app; NOOPiOS stays compile-only) with a concrete runnable destination. On-demand, same as the rest of this workflow.
Owner
Author
|
Superseded by a non-ci/ branch — the app-build cleanup job auto-deletes ci/-prefixed branches, which broke this PR's head ref mid-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app-build.ymlwas compile-only (xcodebuild … build), which left a gap: the app-target unit tests in StrandTests never ran anywhere.swift-packagesonly coversPackages/**, and this workflow only built — so pure app-target logic tests (backfill-continuation predicate #594, scheduled-report / strain-target policy #517/#593, etc.) had been merged compiled but never executed.Change
Adds a macOS-only test step after the build:
xcodebuild -scheme Strand -destination 'platform=macOS' test. StrandTests is hosted in the macOS app (project.ymlwires it into the Strand scheme'stestaction), so:Uses a concrete runnable
platform=macOSdestination fortest(the existingbuildstep keeps its universalgeneric/platform=macOS+ ARCHS for the x86_64 verify). On-demand only, like the rest of this disabled-by-default workflow.Why now
Dispatched on this branch to actually run it — this is the first execution of the app-target test backlog. If green, it clears the long-standing "compiled but never run" caveat on every app-target Swift PR this cycle.