Repository navigation
Conversation
|
Thanks for this, and for the steady localization work — but I'm going to close this one as superseded by #501, which merged a short while ago and already covers exactly this flow. Wanted to leave the details so it's clear it's a timing collision, not a problem with the change itself.
The two efforts just took different key conventions, which is why GitHub flags this CONFLICTING — both rewrite
Merging on top of #501 would either fight the conflict or leave duplicate parallel keys for the same buttons, and the semantic names would be inconsistent with the ~1,500 For what it's worth, your Net: no action needed on your side — #501 got there first. Really appreciate the contribution, and please keep them coming. |
…from the strap trace A workout recorded while the strap link was down is saved without average, peak or Effort, though the strap hands its own trace over at the next sync. Average and peak already followed that trace at read time (ryanbr#77/ryanbr#499); the Effort stayed empty. The analysis pass now stores all three for recorded or entered workouts saved without heart rate, through the same resolver and fill table as the Apple Health fill, in their own namespace, laid over the row at read time. Recorded in docs/fork/decisions.md. Analysis migration required: no. New fills for rows that had no heart rate; nothing already scored changes.
Summary
Progresses #453 by localizing the Android workout-start sheet and active-workout banner.
Why
WorkoutStart.ktpassed its labels directly to Compose as English string literals, so Android could never translate that flow. This moves the screen's UI text throughstringResource()and adds matching German resources.Changes
Sport names come from the shared
WorkoutSportcatalog and remain part of the wider #453 backlog; this PR covers the UI owned byWorkoutStart.ktwithout changing stored sport identifiers.Validation
git diff --checkxmllint --noout android/app/src/main/res/values/strings.xml android/app/src/main/res/values-de/strings.xmlpython3 Tools/i18n_audit.py --platform android --ci upstream/maincd android && ./gradlew :app:testFullDebugUnitTest --tests 'com.noop.ui.GermanLocalizationTest' :app:compileFullDebugKotlin