Repository navigation
Flag HR-only sleep estimates as incomplete - #2879
Open
fadkeprasad wants to merge 1 commit into
Open
fadkeprasad wants to merge 1 commit into
fadkeprasad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
When a night has no gravity samples,
isGravitySparsereturns false because there is no motion span to assess. HR-only sessions are therefore persisted as complete, and the Sleep screen hides its existing short-night warning. This misses the lower-confidence disclosure called for in #1801 and leaves short inferred windows looking authoritative.The change adds a day-level presentation flag for HR-only sessions, preserves the detector's motion-sparsity value for staging and Rest scoring, and updates the warning copy to describe missing or incomplete motion data. iOS and Android behavior and translations are kept aligned.
Type of change
How it was tested
swift test --package-path Packages/StrandAnalytics --filter AnalyticsEngineHrOnlyDayTests— passed.ANDROID_HOME=/Users/prasad/Library/Android/sdk ./gradlew :app:testFullDebugUnitTest --tests com.noop.analytics.AnalyticsEngineHrOnlyDayTest— passed.python3 Tools/i18n_audit.py --ci origin/main— passed.git diff --check— passed.Checklist
Related issues
Refs #1801