Repository navigation
fix(alarm): move per-day wake times into alarm settings - #2700
Open
rodrigosa7 wants to merge 3 commits into
Open
rodrigosa7 wants to merge 3 commits into
rodrigosa7 wants to merge 3 commits into
Conversation
rodrigosa7
force-pushed
the
fix/alarm-per-day-times
branch
from
October 4, 2026 20:25
f38c18b to
a166655
Compare
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Moves per-day wake time editing into the strap alarm card, where it is available without enabling Wind-down nudge. The alarm's default time now supplies the reminder's default wake time, so the two cards no longer expose competing wake-time pickers.
The per-day editor shows only selected alarm weekdays. Deselecting a weekday clears its override, so selecting it again starts from the default time. Wind-down remains an independent on/off choice and uses the same wake times when enabled. The screen no longer shows one reminder time when per-day times differ.
Analysis migration required: no. This changes settings and notification scheduling, not stored analysis values.
Type of change
How it was tested
xcodegen generatecompleted.xcodebuild -project Strand.xcodeproj -scheme Strand -destination 'platform=macOS' -derivedDataPath /private/tmp/noop-ryan-derived CODE_SIGNING_ALLOWED=NO -quiet buildpassed.xcodebuild -project Strand.xcodeproj -scheme NOOPiOS -destination 'generic/platform=iOS' -derivedDataPath /private/tmp/noop-ryan-derived CODE_SIGNING_ALLOWED=NO -quiet buildpassed.git diff --checkpassed.Checklist
swift testinPackages/<name>) — no package touchedandroid/(./gradlew testFullDebugUnitTest; after a branch switch add--no-build-cache --rerun-tasks, or Gradle may fail classes you never touched) — Android unchangedStrandDesigntokens — no hardcoded colors, fonts, or spacingdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Refs #2699. Related: #1864.