Skip to content

fix(alarm): move per-day wake times into alarm settings - #2700

Open
rodrigosa7 wants to merge 3 commits into
ryanbr:mainfrom
rodrigosa7:fix/alarm-per-day-times
Open

rodrigosa7 wants to merge 3 commits into
ryanbr:mainfrom
rodrigosa7:fix/alarm-per-day-times

Conversation

@rodrigosa7

Copy link
Copy Markdown

What this PR does

Moves per-day wake time editing into the strap alarm card, where it is available without enabling Wind-down nudge. The alarm's default time now supplies the reminder's default wake time, so the two cards no longer expose competing wake-time pickers.

The per-day editor shows only selected alarm weekdays. Deselecting a weekday clears its override, so selecting it again starts from the default time. Wind-down remains an independent on/off choice and uses the same wake times when enabled. The screen no longer shows one reminder time when per-day times differ.

Analysis migration required: no. This changes settings and notification scheduling, not stored analysis values.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Documentation
  • CI / tooling

How it was tested

  • xcodegen generate completed.
  • xcodebuild -project Strand.xcodeproj -scheme Strand -destination 'platform=macOS' -derivedDataPath /private/tmp/noop-ryan-derived CODE_SIGNING_ALLOWED=NO -quiet build passed.
  • xcodebuild -project Strand.xcodeproj -scheme NOOPiOS -destination 'generic/platform=iOS' -derivedDataPath /private/tmp/noop-ryan-derived CODE_SIGNING_ALLOWED=NO -quiet build passed.
  • git diff --check passed.
  • No BLE command or protocol code changed. Hardware wake behavior was not tested.

Checklist

  • Swift package tests pass for any package I touched (swift test in Packages/<name>) — no package touched
  • Android unit tests pass if I touched android/ (./gradlew testFullDebugUnitTest; after a branch switch add --no-build-cache --rerun-tasks, or Gradle may fail classes you never touched) — Android unchanged
  • No new build warnings introduced
  • UI changes use only StrandDesign tokens — no hardcoded colors, fonts, or spacing
  • No hardcoded hex frame bytes; protocol facts live in the schema / decoders
  • Follows the conventions in docs/CONTRIBUTING.md
  • I did not commit generated output (Strand.xcodeproj/) or any secrets/keystores

Related issues

Refs #2699. Related: #1864.

@rodrigosa7
rodrigosa7 force-pushed the fix/alarm-per-day-times branch from f38c18b to a166655 Compare October 4, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant