Repository navigation
Bound HealthKit observer deltas to the existing recent sync window - #2642
Merged
ryanbr merged 1 commit intoOct 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The observer anchored query adds the same recent 31-day window its aggregate consumer already processes. A fresh anchor otherwise decodes older samples before that consumer clamps the window. NOOP-authored samples remain excluded, and explicit historical imports keep their separate queries.
How it was tested
The combined fork passed iOS/macOS builds and package checks. This extracted patch applies to the documented upstream base; separate contribution CI is still pending.
Before submission, validate fresh/existing anchors, overlapping boundary samples, day rollover, time-zone changes, and historical imports on a HealthKit-authorized iPhone. The predicate moves while the anchor key stays unchanged; review whether a reset or new key is needed. Existing deletion handling is unchanged. Battery savings have not been measured.