Repository navigation
feat(timeline): add x-axis labels to Deep Timeline - #2445
andigandhi wants to merge 2 commits into
Conversation
…imeline on Android and iOS/macOS
|
Landed in #2520 as your two commits, authorship and messages unchanged. Thanks for this, and for saying outright that you could not test the Apple side: that is what sent me looking at the shared chart rather than assuming it. I stacked one follow-up commit, for something the diff cannot show on its own. The sub-hour tiers now sit behind a On Apple I keyed that flag on Two smaller things in the same commit. The Swift helper was building a I added One consequence worth writing down for whoever reads this later: because |
What this PR does
Currently, the deep timeline does not have x-axis labels. This makes chart analysis very hard.
This pull request adds x-axis lables which scale according to the zoom level of the graph.
Type of change
How it was tested
Android app was tested on a real device. The scaling of the lables seemd good.
I was not able to test the changes in the iOS App!
Checklist
swift testinPackages/<name>)android/(./gradlew testFullDebugUnitTest)StrandDesigntokens — no hardcoded colors, fonts, or spacingdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystores