Repository navigation
test: import WhoopProtocol in SleepFragmentedNightTests - #1986
Merged
Merged
Conversation
The end-to-end fixture added in #1984 builds GravitySample and HRSample values, which live in WhoopProtocol, not StrandAnalytics. The file imported only StrandAnalytics, so test (StrandAnalytics) failed to compile with "cannot find type 'GravitySample' in scope". The sibling fixture file this was modelled on, SleepStagerActiveBridgeTests, carries the same import for the same reason. Swift cannot be compiled in the WSL dev environment, so this was invisible until CI ran the package leg.
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end-to-end fixture added in #1984 builds GravitySample and HRSample
values, which live in WhoopProtocol, not StrandAnalytics. The file imported
only StrandAnalytics, so test (StrandAnalytics) failed to compile with
"cannot find type 'GravitySample' in scope". The sibling fixture file this
was modelled on, SleepStagerActiveBridgeTests, carries the same import for
the same reason.
Swift cannot be compiled in the WSL dev environment, so this was invisible
until CI ran the package leg.
Restores
test (StrandAnalytics), which is red on main.