Repository navigation
Require continuous effort for heart-rate recovery eligibility - #1901
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes heart-rate recovery eligibility on Swift and Android to require one continuous qualifying effort of at least two minutes. Previously, separate high-heart-rate fragments could be added together and incorrectly qualify a workout.
The calculation keeps the existing threshold, left-sample interval attribution, 10-second gap cap, duplicate-timestamp handling, recovery windows, and score outputs.
Type of change
How it was tested
WhoopProtocoldependency in a minimal Linux package.HeartRateRecoveryTestpasses throughtestFullDebugUnitTest.This is a pure analytics change and does not touch BLE behavior. No physical strap was tested. Local focused verification ran on Linux; the complete Swift package suite subsequently passed on macOS in Swift Packages CI, and the complete Android unit suite passed in Android CI.
Checklist
swift testinPackages/<name>) — complete StrandAnalytics package tests passed in macOS CI.android/(./gradlew testFullDebugUnitTest) — complete unit suite passed in Android CI.StrandDesigntokens — no UI changesdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Fixes bhelm#55.