Repository navigation
Canonicalize signed zero in effective effort - #1792
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonicalize the both-present signed-zero case to positive zero in the mirrored Swift and Kotlin analytics implementations. This removes the platform-dependent tie behavior of Swift.max and kotlin.math.max while preserving nil passthrough, nonzero ordering/equality, infinities, and NaN operand-order behavior.\n\nAdds mirrored raw-bit regression coverage for all four signed-zero operand combinations plus preservation cases.\n\nRelated issue: https://github.com/bhelm/noop/issues/37\n\nVerification:\n- Swift EffectiveEffortTests: 10 tests, 0 failures\n- Android EffectiveEffortTest: BUILD SUCCESSFUL\n- git diff --check\n- Two independent reviews: no P0/P1 findings