Repository navigation
iOS: "Sky behind cards" parity — day-cycle sky behind the whole Today scroll (opt-in) - #16
Merged
Merged
Conversation
…whole Today scroll (opt-in) Mirrors the Android PR (#15). The liquid Today sky is a 340 top band, so Card transparency only reveals it behind the hero; lower cards fade toward the flat canvas. Add the opt-in "Sky behind cards" toggle (Settings → Appearance, default OFF): - LiquidSky / LiquidSkyStatic gain a settleStrength (1 = default seamless fade-to-canvas; 0.78 in fill mode so the horizon tint survives behind the scroll instead of dissolving to dark). - LiquidTodayView backdrop fills the whole view (drops the 340 frame) with the softer settle when the toggle is on. - New SkyBehindCardsPrefs.enabledKey ("noop.skyBehindCards"), shared with the Settings Toggle; matches the Kotlin NoopPrefs.skyBehindCards key so the pref reads the same. Default OFF = zero change for existing users.
ryanbr
added a commit
that referenced
this pull request
Jul 7, 2026
iOS: liquid Today honours the Day-cycle background toggle (closes #16 parity gap)
tanarchytan
pushed a commit
to tanarchytan/noop
that referenced
this pull request
Jul 7, 2026
Closes the last parity gap from ryanbr#16. iOS`\s LiquidTodayView always drew the sky, ignoring the "Day-cycle background" setting — so turning it off did NOT give the plain dark canvas it does on Android and the classic TodayView. The "Sky behind cards" switch was therefore standalone on iOS vs day-cycle-gated on Android. - Gate the LiquidTodayView sky on @AppStorage(SceneBackgroundPrefs.enabledKey); off = the plain surfaceBase canvas (matches Android + classic Today). - Disable/grey the "Sky behind cards" Settings toggle when the day-cycle background is off (the sky it extends is not drawn then) — mirrors the Android `enabled = showDayCycleBackground`.
DX23876
referenced
this pull request
in DX23876/noop
Jul 22, 2026
iOS: "Sky behind cards" parity — day-cycle sky behind the whole Today scroll (opt-in)
DX23876
referenced
this pull request
in DX23876/noop
Jul 22, 2026
Closes the last parity gap from #16. iOS`\s LiquidTodayView always drew the sky, ignoring the "Day-cycle background" setting — so turning it off did NOT give the plain dark canvas it does on Android and the classic TodayView. The "Sky behind cards" switch was therefore standalone on iOS vs day-cycle-gated on Android. - Gate the LiquidTodayView sky on @AppStorage(SceneBackgroundPrefs.enabledKey); off = the plain surfaceBase canvas (matches Android + classic Today). - Disable/grey the "Sky behind cards" Settings toggle when the day-cycle background is off (the sky it extends is not drawn then) — mirrors the Android `enabled = showDayCycleBackground`.
DX23876
referenced
this pull request
in DX23876/noop
Jul 22, 2026
iOS: liquid Today honours the Day-cycle background toggle (closes #16 parity gap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS parity for #15 (Android). The liquid Today sky is a 340 top band, so Card transparency only reveals it behind the hero; lower cards fade toward the flat canvas.
Adds the same opt-in Settings → Appearance → "Sky behind cards" toggle (default OFF) that extends the sky behind the whole Today scroll.
How (mirrors the Android knobs)
LiquidSky/LiquidSkyStaticgain asettleStrength—1keeps the current seamless fade-to-canvas; fill mode uses0.78so the horizon tint survives behind the scroll instead of dissolving to dark.LiquidTodayView’s backdrop drops the340frame (fills the view) with the softer settle when the toggle is on.SkyBehindCardsPrefs.enabledKey="noop.skyBehindCards"— the same key as KotlinNoopPrefs.skyBehindCards, shared with the SettingsToggle.Scope / safety
Verify