Repository navigation
Fix Swift SleepStagerV2 shuffled-input clipping - #1456
Merged
Merged
Conversation
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes the Swift public
SleepStagerV2.stageSessionestablish stable timestamp order before binary-search clipping, matching the Kotlin twin. Already-monotonic streams keep the allocation-free fast path; only genuinely shuffled inputs allocate a stable reorder. The uncached recipe consumes the already-ordered clipped streams directly, preserving same-second emission order.Permanent mirrored native tests cover deterministic shuffled streams, freeze the existing sorted-input result, and use cache-isolated translated windows to prove two order-sensitive same-timestamp gravity outcomes remain distinct while timestamp-group shuffling preserves each outcome. Padding constants and the parity rollout harness are unchanged.
Type of change
How it was tested
6df88d0d: the permanent Swift shuffled-input regression failed with sorted all-light versus shuffled light+REM.:app:testFullDebugUnitTest: passed.SleepStagerV2Test: passed under the same resource limits.Compressionmodule inWhoopStore/RawOutbox.swift; the fork full Swift suite and focused final Swift regression are green.Checklist
swift testinPackages/<name>)android/(./gradlew testFullDebugUnitTest)StrandDesigntokens — no hardcoded colors, fonts, or spacingdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Tracked in bhelm#67.