Repository navigation
fix(recovery): align charge driver half-ties - #1441
Merged
Merged
Conversation
9 of 10 tasks
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Defines one cross-platform integer rounding rule for Charge driver marginal points: nearest, with exact half-ties away from zero. Kotlin now matches the existing Swift behavior for negative half-ties, while the Recovery score and all other driver fields remain unchanged.
Type of change
How it was tested
RecoveryDriversTestran 9 tests with exactly 2 expected failures before the fix: the negative-0.5boundary and the real issue reproduction through the default eighth argument.ChargeDriversTestspassed 14/14 before the Kotlin fix.ChargeDriversTestspassed 14/14; the three established Linux compatibility gates were applied only for the run and fully reverted afterward.RecoveryDriversTestpassed 9/9 with JDK 17, one worker, no parallel Gradle execution, and the Kotlin compiler in-process.-0.5,+0.5, neighboring non-ties, the exact seven-argument/default-arg8 reproduction, unchanged Recovery score, and the complete driver row.Checklist
swift testinPackages/<name>)android/(./gradlew testFullDebugUnitTest)StrandDesigntokens — no UI changesdocs/CONTRIBUTING.mdThe two full-suite checklist items remain unchecked because this bounded fix ran the requested focused native regression suites.
Related issues
Fork issue: bhelm#51