v2: pin Rust 1.89 and fix sensing-server UI path when run from v2#523
Merged
Merged
Conversation
ruvector-core 2.0.5, hnsw_rs 0.3.4, and mmap-rs 0.7 require newer Cargo/rustc than 1.82 (edition2024 manifest, is_multiple_of, stable avx512f target_feature on x86_64). Add v2/rust-toolchain.toml so cargo build -p wifi-densepose-sensing-server picks a compatible toolchain. Signed-off-by: Chaitanya Tata <chaitanya@dotstarconsulting.com> Co-authored-by: Cursor <cursoragent@cursor.com>
The previous default ../../ui resolves to a non-existent directory when the binary is run from v2/ (common), so /ui/* returned 404 and the dashboard appeared broken. Default to ../ui and try ../ui, ./ui, ../../ui when the configured path is missing. Signed-off-by: Chaitanya Tata <chaitanya@dotstarconsulting.com> Co-authored-by: Cursor <cursoragent@cursor.com>
krish2718
force-pushed
the
pr/v2-sensing-server-toolchain-ui
branch
from
May 10, 2026 15:56
b305410 to
2d9e1bc
Compare
ruvnet
approved these changes
May 17, 2026
ruvnet
left a comment
ruvnet
left a comment
Owner
There was a problem hiding this comment.
Three small, safe, on-target changes:
v2/rust-toolchain.tomlpinning Rust 1.89 — explicitly states what the existing edition-2024 /mmap-rschain already requires implicitly. Eliminates the 'wrong rustc' first-time-build failure.--ui-pathdefault../ui— assumescd v2 && cargo run, which matchesCLAUDE.md's build-test commands. The prior../../uiworked only fromv2/crates/wifi-densepose-sensing-server/.coalesce_ui_path()fallback — gracefully recovers from a wrong cwd by trying the three common layouts, logging awarnso the operator knows. Right-sized: not magic, but stops a blank-UI bug from being a head-scratcher.
Merging.
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the sensing server and its static UI usable from a normal
v2/checkoutwithout hand-editing paths, and pin a Rust toolchain that matches the workspace
dependency graph (edition 2024 / newer APIs).
Changes
v2/rust-toolchain.tomlpinning Rust 1.89 (required by the currentmmap-rs/ edition-2024 chain and related crates in this workspace).../ui(repo layout:ui/nextto
v2/), and coalesce fallbacks (../ui,./ui,../../ui) when the defaultis missing so
cargo runfromv2/does not serve an empty/ui.Test plan
cd v2 && cargo build -p wifi-densepose-sensing-serverv2/with default args; open the dashboard and confirmassets load (no blank UI).
Notes
Toolchain pin is repo-wide for
v2/viarust-toolchain.toml, not only thesensing server crate; the PR title calls out sensing-server because that is the
user-visible workflow fixed alongside UI path resolution.