small test and documentation fixes - #347
Merged
Merged
Conversation
Previously the result from adding a PEM input file to a root cert store wasn't being checked.
jsha
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling out a handful of small changes from #341 that can be landed immediately without blocking on a finalized Rustls release.
tests: fix f-string in client-server.py
Another instance of a f-string gone awry. It might be nice to RIIR this integration test driver, or invest in more Python CI capabilities (like running
flake8) to catch this class of bug sooner.tests: print headers for client/server test types
I was finding it challenging to quickly scan the client/server integration test output to identify which scenario was failing. This commit adds some headers to make that easier.
tests: check add pem result in server.c
Previously the result from adding a PEM input file to a root cert store wasn't being checked. This was an omission from #321 Unfortunately it seems
clang-tidydoesn't catch this 😢 My kingdom for#[must_use]return type annotations.lib: note BoxCastPtr/ArcCastPtr are mutually exclusive
As discussed in #341, only one of
BoxCastPtrorArcCastPtrshould be implemented for a type