Skip to content

test(cli): cover cors required field validation #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
overtrue wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(cli): cover cors required field validation #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions crates/cli/src/commands/cors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,7 @@ mod tests {
fn test_parse_bucket_path_error() {
assert!(parse_bucket_path("").is_err());
assert!(parse_bucket_path("local").is_err());
assert!(parse_bucket_path("local/").is_err());
assert!(parse_bucket_path("/bucket").is_err());
assert!(parse_bucket_path("local///").is_err());
}
Expand Down Expand Up @@ -591,6 +592,40 @@ mod tests {
assert!(error.contains("unsupported method"));
}

#[test]
fn test_parse_cors_configuration_rejects_missing_allowed_origin() {
let error = parse_cors_configuration(
r#"{
"rules": [
{
"allowedOrigins": [],
"allowedMethods": ["GET"]
}
]
}"#,
)
.expect_err("missing allowed origin");

assert!(error.contains("at least one allowed origin"));
}

#[test]
fn test_parse_cors_configuration_rejects_missing_allowed_method() {
let error = parse_cors_configuration(
r#"{
"rules": [
{
"allowedOrigins": ["*"],
"allowedMethods": []
}
]
}"#,
)
.expect_err("missing allowed method");

assert!(error.contains("at least one allowed method"));
}

#[test]
fn test_parse_cors_configuration_rejects_empty_allowed_origin() {
let error = parse_cors_configuration(
Expand Down