Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change closes a small test gap in the recent bucket event command work. The event bucket path parser accepted inputs like
alias///, because it trimmed trailing slashes after splitting but did not re-check whether the resulting bucket segment was still non-empty.In practice that meant an invalid path could make it past argument parsing and fail later in a less precise code path. The
corscommand already rejects the same shape, so the event command was inconsistent with adjacent bucket command behavior.Root cause
parse_bucket_pathincrates/cli/src/commands/event.rsonly validated the raw second path segment before trimming trailing slashes. For an input such aslocal///, the pre-trim segment was non-empty, but the normalized bucket name became empty.Fix
The parser now trims trailing slashes into a local
bucketvariable and rejects the path when that normalized bucket value is empty. A focused unit test was added to prove thatlocal///is invalid.Validation
I first added the new assertion and verified it failed against the current implementation with:
cargo test -p rustfs-cli parse_bucket_path_error -- --nocaptureAfter the fix, I re-ran focused and repo-wide validation:
cargo test -p rustfs-cli commands::event:: -- --nocapturecargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceI also attempted
make pre-commitper the automation constraint, but this checkout does not contain apre-commitmake target onorigin/main.