wayland: don't send set_buffer_scale on wl_surface below version 3#4622
Merged
ogoffart merged 1 commit intoJul 9, 2026
Merged
Conversation
wl_surface::set_buffer_scale is available since version 3. Sending it on an older surface is a protocol error that terminates the connection. This could happen when setting a custom cursor on a compositor without wp_viewporter. The neighboring damage call already checks the version.
Contributor
Author
|
Note: this wasn't tested. This just came up as I scanned the code with AI tools in the context of reviewing another PR, and wanted to verify what was the lower version of the protocol we support unconditionally. |
kchibisov
approved these changes
Jul 9, 2026
kchibisov
left a comment
kchibisov
left a comment
Member
There was a problem hiding this comment.
it's ok, but doubt v3 exists, most things mandate something recent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wl_surface::set_buffer_scale is available since version 3. Sending it on an older surface is a protocol error that terminates the connection. This could happen when setting a custom cursor on a compositor without wp_viewporter. The neighboring damage call already checks the version.