winit-win32: fix request_redraw can be ignored while the system popup menu is shown#4609
Open
rhysd wants to merge 1 commit into
Open
winit-win32: fix request_redraw can be ignored while the system popup menu is shown#4609rhysd wants to merge 1 commit into
request_redraw can be ignored while the system popup menu is shown#4609rhysd wants to merge 1 commit into
Conversation
while the system popup is shown.
rhysd
changed the title
redraw_requested can be ignored while the system popup is shownredraw_requested can be ignored while the system popup menu is shown
rhysd
changed the title
redraw_requested can be ignored while the system popup menu is shownrequest_redraw can be ignored while the system popup menu is shown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersFixes #4608
This PR makes winit event loop track the menu loop state. In the menu loop, redraw requests are kept pending. And the redraw is called when the menu loop exits (if some request is pending). This is necessary because redraw is ignored while the menu loop is active.