Repository navigation
build(deps): update windows-sys requirement from 0.52 to 0.61 - #1753
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
MarijnS95
force-pushed
the
dependabot/cargo/windows-sys-0.61
branch
2 times, most recently
from
July 22, 2026 11:59
63e217e to
f000c50
Compare
MarijnS95
reviewed
Jul 22, 2026
kchibisov
requested changes
Jul 23, 2026
Updates the requirements on [windows-sys](https://github.com/microsoft/windows-rs) to permit the latest version. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows-sys dependency-version: 0.61.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
MarijnS95
force-pushed
the
dependabot/cargo/windows-sys-0.61
branch
from
July 23, 2026 15:00
f000c50 to
6983147
Compare
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on windows-sys to permit the latest version.
Manual changes required for
windows-sys0.61Since
windows-sys0.59 the Win32 handle aliases (HWND,HDC,HGLRC,HMODULE,HMENU, ...) are raw pointers (*mut c_void) instead of integers (microsoft/windows-rs#3093, landed in microsoft/windows-rs#3111). This is a breaking change that required adapting glutin's WGL/EGL code on top of the version bump:0→std::ptr::null_mut()for theCreateWindowExWhWndParent/hMenuargs and the confighwndfallback, and== 0→.is_null()forwin,lib_opengl32and the EGL native pixmap. The now-redundant#[cfg(windows)]/#[cfg(not(windows))]split around the pixmap null check was dropped since both platforms use a pointer.Send/Sync— raw pointers are neitherSendnorSync, soDisplayInner(holdingHMODULE) andConfigInner(holdingHDC) lost their auto-derived thread-safety, which cascaded intoConfig/Contextand broke theirSend/Syncdoc-tests. Introduced dedicatedOpenGlModule(HMODULE)andDeviceContext(HDC)newtypes that scope theunsafe impl Send/Syncto just the handle (mirroring the existingWglContext(HGLRC)pattern) rather than blanket-impl'ing over the whole struct.Verified against
x86_64-pc-windows-msvcthatConfig/DisplayareSend + Sync,Surface/NotCurrentContextareSendbut notSync, andPossiblyCurrentContextis neither — matching the existing doc-test invariants.Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)