Add detail to PR welcome msg#1684
Merged
Mark-Simulacrum merged 1 commit intoMar 1, 2023
Merged
Conversation
Mark-Simulacrum
approved these changes
Mar 1, 2023
ehuss
reviewed
Mar 1, 2023
ehuss
left a comment
ehuss
left a comment
Contributor
There was a problem hiding this comment.
These commands only work on repositories that have the [shortcut] table configured. Most do, but not all of them. I don't have a particular solution for that, since the handlers can't see the config of other handlers (maybe something to address?). I'm slightly concerned that may lead to confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to improve on the pull request review flow. This patch add additional info on how to use the review flags during the lifecycle of a pull request. See also the patch to update the documentation: rustc-dev-guide#1628.
Discussed during T-compiler meeting (comment).
thanks!
r? @Mark-Simulacrum