Skip to content

feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION - #4259

Merged
rami3l merged 6 commits into
rust-lang:masterfrom
rami3l:feat/downgrade
Mar 19, 2025
Merged

feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION#4259
rami3l merged 6 commits into
rust-lang:masterfrom
rami3l:feat/downgrade

Conversation

@rami3l

@rami3l rami3l commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1158.

I think the following console log should suffice to explain what this PR does (no tests for the .sh script, but works on my machine):

> RUSTUP_VERSION=1.26.0 ./rustup-init.sh --version
info: `RUSTUP_VERSION` has been set to `1.26.0`
info: downloading installer
rustup-init 1.26.0 (5af9b9484 2023-04-05)

The same environment variable now also applies to rustup self update, which does come with a proper test.

@rami3l
rami3l requested review from ChrisDenton and djc March 19, 2025 14:13
@rami3l rami3l changed the title feat: allow arbitrary downgrade via the RUSTUP_VERSION environment variable feat: allow version pinning/arbitrary downgrade RUSTUP_VERSION Mar 19, 2025
@rami3l rami3l changed the title feat: allow version pinning/arbitrary downgrade RUSTUP_VERSION feat: allow version pinning/arbitrary downgrade via RUSTUP_VERSION Mar 19, 2025
@rami3l rami3l changed the title feat: allow version pinning/arbitrary downgrade via RUSTUP_VERSION feat: allow version pinning & arbitrary downgrades via RUSTUP_VERSION Mar 19, 2025
ChrisDenton
ChrisDenton reviewed Mar 19, 2025
View reviewed changes
Comment thread src/config.rs Outdated
rami3l
rami3l commented Mar 19, 2025
View reviewed changes
Comment thread src/config.rs Outdated
@rami3l
rami3l enabled auto-merge March 19, 2025 15:22
@rami3l
rami3l added this pull request to the merge queue Mar 19, 2025
Merged via the queue into rust-lang:master with commit 3b60eb2 Mar 19, 2025
@rami3l
rami3l deleted the feat/downgrade branch March 19, 2025 15:48
@ChrisDenton ChrisDenton mentioned this pull request Apr 4, 2025
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Aug 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes
@djc djc Awaiting requested review from djc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make downgrading via the archives work

2 participants

@rami3l @ChrisDenton